Skip to content

chore: improve docker tests #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 19, 2023
Merged

chore: improve docker tests #2514

merged 7 commits into from
Feb 19, 2023

Conversation

divine
Copy link
Contributor

@divine divine commented Feb 19, 2023 •
edited
Loading

Currently it's not possible to run test when running docker-compose up as the test container just stops silently and it's possible to run it again.

After this merge it would be possible to run tests just by starting up the container and it'll just work.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023 •
edited
Loading

Codecov Report

Base: 89.91% // Head: 89.91% // No change to project coverage 👍

Coverage data is based on head (c380ce3) compared to base (7dab675).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2514   +/-   ##
=========================================
  Coverage     89.91%   89.91%           
  Complexity      712      712           
=========================================
  Files            32       32           
  Lines          1726     1726           
=========================================
  Hits           1552     1552           
  Misses          174      174

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@divine divine requested a review from Smolevich February 19, 2023 16:35
Smolevich
Smolevich reviewed Feb 19, 2023
View reviewed changes
Smolevich
Smolevich reviewed Feb 19, 2023
View reviewed changes
Smolevich
Smolevich reviewed Feb 19, 2023
View reviewed changes
Smolevich
Smolevich reviewed Feb 19, 2023
View reviewed changes
Smolevich
Smolevich reviewed Feb 19, 2023
View reviewed changes
@Smolevich
Copy link
Contributor

Add minimal description, please
I understand your motivation but another contributors don't understand reason of your changes

@divine
Copy link
Contributor Author

divine commented Feb 19, 2023

Add minimal description, please I understand your motivation but another contributors don't understand reason of your changes

I've added description,

Thank you for your review.

@Smolevich Smolevich merged commit 57010c0 into master Feb 19, 2023
@divine divine deleted the improve-docker branch February 19, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smolevich Smolevich Smolevich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divine @codecov-commenter @Smolevich